Add logs on voltage limits #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dupplicate code
generated code not marked as it for coverage
Tristan-WorkGH
force-pushed
the
add_logs
branch
from
e9aa164 to
e5c47e8
Compare
Tristan-WorkGH
force-pushed
the
add_logs
branch
from
e5c47e8 to
fc7e221
Compare
ne0ds
reviewed
Mar 26, 2024
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Moved to #51
ne0ds
reviewed
Mar 26, 2024
There was a problem hiding this comment.
The project was missing .mvn/lombok-config-copy.marker & lombok.config, with consequence of very bad coverage with Sonar for example.
ne0ds
reviewed
Mar 26, 2024
There was a problem hiding this comment.
use common lombok config as base
etiennehomer
requested changes
Mar 26, 2024
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
src/main/java/org/gridsuite/voltageinit/server/service/VoltageInitRunContext.java
Show resolved
Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java
Show resolved
Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java
Show resolved
Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java
Outdated
Show resolved
Hide resolved
src/test/java/org/gridsuite/voltageinit/utils/assertions/ReflectiveRepresentation.java
Outdated
Show resolved
Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java
Outdated
Show resolved
Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java
Outdated
Show resolved
Hide resolved
etiennehomer
requested changes
Mar 26, 2024
src/test/java/org/gridsuite/voltageinit/server/VoltageInitParametersTest.java
Outdated
Show resolved
Hide resolved
antoinebhs
requested changes
Apr 8, 2024
src/main/java/org/gridsuite/voltageinit/server/service/VoltageInitWorkerService.java
Show resolved
Hide resolved
src/main/java/org/gridsuite/voltageinit/server/service/VoltageInitRunContext.java
Outdated
Show resolved
Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java
Outdated
Show resolved
Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java
Outdated
Show resolved
Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java
Outdated
Show resolved
Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java
Outdated
Show resolved
Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java
Outdated
Show resolved
Hide resolved
|
|
||
| long nanoTime = System.nanoTime(); | ||
| LOGGER.info("Parameters built in {}s", TimeUnit.NANOSECONDS.toSeconds(System.nanoTime() - startTime.getAndSet(nanoTime))); | ||
| LOGGER.info("Parameters built in {}s", TimeUnit.NANOSECONDS.toSeconds(System.nanoTime() - startTime)); |
There was a problem hiding this comment.
Not necessary for this PR, to revert
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java
Outdated
Show resolved
Hide resolved
antoinebhs
reviewed
Apr 9, 2024
src/test/java/org/gridsuite/voltageinit/server/VoltageInitParametersTest.java
Show resolved
Hide resolved
Signed-off-by: Tristan Chuine <[email protected]>
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java
Outdated
Show resolved
Hide resolved
This reverts commit 5e6bdda.
etiennehomer
requested changes
Apr 10, 2024
src/main/java/org/gridsuite/voltageinit/server/service/VoltageInitRunContext.java
Show resolved
Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java
Outdated
Show resolved
Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java
Outdated
Show resolved
Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java
Outdated
Show resolved
Hide resolved
etiennehomer
approved these changes
Apr 10, 2024
antoinebhs
reviewed
Apr 10, 2024
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.